[alsa-devel] [PATCH][Trivial] Delete trailing whitespace from sound/soc/codecs/wm8994.c

Jiri Kosina jkosina at suse.cz
Mon Apr 9 02:29:23 CEST 2012


On Mon, 9 Apr 2012, Michael Witten wrote:

> >> While reading through sound/soc/codecs/wm8994.c I noticed a fair
> >> amount of trailing whitespace. This patch gets rid of it.
> >>
> >> Signed-off-by: Jesper Juhl <jj at chaosbits.net>
> >
> > Jesper,
> >
> > is it really worth it? The code should have been fixed before merging,
> > yes, but once it's there, such fixups tend to only make people angry
> > (because they have to do unnecessary extra steps during git blame).
> 
> If I may interject, I assume you mean that nobody wants to see the
> fact that somebody simply changed whitespace. However, the text of
> `git help blame' suggests that the `-w' flag obviates the issue:
> 
>   Ignore whitespace when comparing the parent's
>   version and the child’s to find where the lines
>   came from.
> 
> Of course, I've never used it, so I may be mistaken in my 
> interpretation.

That indeed does what it should do, but as it's not git default, then 
quitting git blame and reruning it with '-w' seems to be equally annoying 
to quitting git blame and reruning it with 'particular_commit~1"

-- 
Jiri Kosina
SUSE Labs


More information about the Alsa-devel mailing list