[alsa-devel] [PATCH] ASoC: wm9712: Fix build due to missing definition of "runtime"
festevam at gmail.com
Tue Apr 10 23:48:47 CEST 2012
On Tue, Apr 10, 2012 at 6:38 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Apr 10, 2012 at 06:33:07PM -0300, Fabio Estevam wrote:
>> Fix the following build error:
>> sound/soc/codecs/wm9712.c:482:32: error: 'runtime' undeclared (first use in this function)
>> sound/soc/codecs/wm9712.c:499:33: error: 'runtime' undeclared (first use in this function)
> On second thoughts looking at what the setting is being used for
> applied... the code is rather odd here, though.
> In general changes like this which make no attempt to understand what
> they're changing are a bad idea - don't just cut'n'paste some errors
> into your changelog, explain what's gone wrong and why. It's like when
> people just initialise a variable to some random value to shut a warning
> up without understanding why, the fact that the error goes away doesn't
> mean that the fix is sensible.
Ok, this is currently breaking imx_v4_v5_defconfig in linux-next and
would like to get it fixed.
I will try to understand this breakage better.
More information about the Alsa-devel