[alsa-devel] [PATCH 1/5] ASoC: sh: fsi: add fsi-codec card support

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Apr 2 23:39:28 CEST 2012

On Sun, Apr 01, 2012 at 06:32:27PM -0700, Kuninori Morimoto wrote:

> --- /dev/null
> +++ b/sound/soc/sh/fsi-codec.c

A more descriptive name (even if it's just fsi-simple-codec or
something) would be nice.

> +	if (pinfo->codec_fmt) {

> +	if (pinfo->cpu_fmt) {

I'd expect that these should always be the same, it's probably as well
to just have one format and then require anyone who wants anything
unusual to handle it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120402/ba687d08/attachment.sig 

More information about the Alsa-devel mailing list