[alsa-devel] [PATCH 1/3] ASoC: omap-mcbsp: Prepare for init time DAI format setting

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Sep 30 16:00:38 CEST 2011

On Fri, Sep 30, 2011 at 04:07:44PM +0300, Jarkko Nikula wrote:
> Before commit 75d9ac4 ("ASoC: Allow DAI formats to be specified in the
> dai_link") expectation for omap-mcbsp was that snd_soc_dai_set_fmt is to be
> called first in machine hw_params callback before other CPU DAI functions.
> Thus it was enough that only omap_mcbsp_dai_set_dai_fmt cleared the
> mcbsp->regs structure.

> Now this doesn't hold anymore since machine drivers can set the DAI format
> only once on init time and thus mcbsp->regs may get out of sync when other

Note that it's only been convention that stopped this happening in the
past, there's never been anything stopping drivers doing this in the
link init function.

More information about the Alsa-devel mailing list