[alsa-devel] [patch] ALSA: usb-audio - NULL dereference on probe error

Dan Carpenter dan.carpenter at oracle.com
Tue Sep 27 09:44:07 CEST 2011


There was a potential NULL dereference introduced in 362e4e49abe
"ALSA: usb-audio - clear chip->probing on error exit"

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/sound/usb/card.c b/sound/usb/card.c
index cc08588..8db260f 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -532,7 +532,8 @@ snd_usb_audio_probe(struct usb_device *dev,
  __error:
 	if (chip && !chip->num_interfaces)
 		snd_card_free(chip->card);
-	chip->probing = 0;
+	if (chip)
+		chip->probing = 0;
 	mutex_unlock(&register_mutex);
  __err_val:
 	return NULL;


More information about the Alsa-devel mailing list