[alsa-devel] [PATCH 06/10] ASoC: twl6040: correct loop counters for HS/HF ramp code

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Sep 27 13:12:34 CEST 2011


On Tue, Sep 27, 2011 at 09:21:14AM +0300, Péter Ujfalusi wrote:
> On Monday 26 September 2011 22:33:01 Mark Brown wrote:
> > On Mon, Sep 26, 2011 at 04:26:29PM +0300, Peter Ujfalusi wrote:
> > > -	for (i = 0; i <= 16; i++) {
> > > +	for (i = 0; i <= 15; i++) {

> > It'd seem more natural to change these to being simple < comparisons -
> > they're far more common.  Any great reason for going tis way (perhaps
> > context?).

> No particular reason IMHO, just a copy from the wm8350 driver.
> I'll check how they look like in assembly, it could be that <= is better in 
> ARM?

It's not like it's getting used throughout the rest of the code and
that's a trivial optimization for a compiler...


More information about the Alsa-devel mailing list