[alsa-devel] [PATCH] ALSA: HDA: Refactor Realtek's automute
tiwai at suse.de
Tue Sep 20 17:01:36 CEST 2011
At Tue, 20 Sep 2011 12:26:30 +0200,
David Henningsson wrote:
> Ok, my automute refactoring has been rebased to your latest tree. I've
> tested it on my own machine, but I don't know if wider testing is needed
> to ensure there are no regressions.
alc_simple_setup_automute() calls can be more simplified.
The function can check spec->autocfg.line_out_pins, hp_pins and
speaker_pins to identify detect_hp & co flags. Otherwise, the
arguments "1, 0, 0, 1" are hard to understand.
Other than that, the patch looks good to me.
More information about the Alsa-devel