[alsa-devel] [PATCH] ASoC: Ensure we generate a card name
broonie at opensource.wolfsonmicro.com
Tue Sep 20 14:19:14 CEST 2011
On Tue, Sep 20, 2011 at 02:12:15PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > > Better to replace any letter except [a-zA-Z0-9_] with '_' or drop
> > > them. Use isalnum(), for example.
> > What *are* the rules? The documentation says "driver name" which isn't
> > verbose...
> It's used as an id string, so you can guess.
> Practically, it should be a single word, contain no dangerous letters
> that may screw up the parser.
I'm inclined to just stick with the original patch then, I'd expect that
anything that's problematic for the driver name is also going to be an
issue in the main name field and it's a lot simpler to implement (we
don't have isalnum() in kernel right now and you still need to handle _
and possibly -).
More information about the Alsa-devel