[alsa-devel] [PATCH] alsa-lib: if card driver name is empty string, use card name instead

Scott Jiang scott.jiang.linux at gmail.com
Tue Sep 20 12:36:15 CEST 2011


2011/9/20 Mark Brown <broonie at opensource.wolfsonmicro.com>:
> On Tue, Sep 20, 2011 at 09:12:19AM +0200, Takashi Iwai wrote:
>> Scott Jiang wrote:
>
>> > I agree with you, but my driver patch has been rejected by Mark.
>
>> That's bad.  But it's a rule since over 10 years ago: the driver
>> should set driver field.
>
> Scott, as I've said every time you've posted your patch there's several
> problems with your patch:
>
>  - The name you've chosen is really not at all suitable, it doesn't
>   identify the system at all.
I said I wound modify the name. But I want to know how to fix this
problem before I send a new patch.

>  - This clearly isn't something that affects only one driver - no ASoC
>   driver sets a driver name - so a change to a single driver is clearly
>   not a good solution even for just Blackfin.
>
I thought about this. I wanted to copy codec name to driver name as
before in asoc but I don't think it's a good idea.
Now we can have multicodecs in one card, they may not be the same, right?
If yes, we should add this name in each snd_soc_card.


More information about the Alsa-devel mailing list