[alsa-devel] [PATCH] alsa-lib: if card driver name is empty string, use card name instead

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Sep 20 12:14:34 CEST 2011


On Tue, Sep 20, 2011 at 08:24:52AM +0200, Takashi Iwai wrote:
> Scott Jiang wrote:

> > Some drivers don't have a card driver name, but they have a nice card name containing enough info.
> > So we can use card name to search card config if we found driver name is not valid.

> It's rather a bug of driver, no?
> I don't think we need to work around it.

This was introduced by your commit 873bd4 (ASoC: don't set invalid name
string to snd_card->driver field) which means we no longer provide a
driver name for any ASoC cards as they're all relying on using the card
name as the driver name.  We should be doing something like replacing '
' by '_' in the driver name we generate rather than just not generating
a name.

I have to confess I didn't review the patch at the time as it was
applied too quickly after it was mailed out for me to have a chance to
see it.  Sorry about that.


More information about the Alsa-devel mailing list