[alsa-devel] [PATCH 4/4] src/pcm/pcm_multi.c: add missing free

Julia Lawall julia at diku.dk
Sun Sep 18 22:04:37 CEST 2011


From: Julia Lawall <julia at diku.dk>

Something that is allocated using calloc is not freed on an error path.

Signed-off-by: Julia Lawall <julia at diku.dk>
Signed-off-by: Suman Saha <sumsaha at gmail.com>

---
Compile-tested only.

 src/pcm/pcm_multi.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/pcm/pcm_multi.c b/src/pcm/pcm_multi.c
index 68f2d68..6b39c7a 100644
--- a/src/pcm/pcm_multi.c
+++ b/src/pcm/pcm_multi.c
@@ -886,6 +886,8 @@ int snd_pcm_multi_open(snd_pcm_t **pcmp, const char *name,
 	err = snd_pcm_new(&pcm, SND_PCM_TYPE_MULTI, name, stream,
 			  multi->slaves[0].pcm->mode);
 	if (err < 0) {
+		free(multi->slaves);
+		free(multi->channels);
 		free(multi);
 		return err;
 	}



More information about the Alsa-devel mailing list