[alsa-devel] [PATCH v3 1/1] ASoC: mxs-saif: add record function

Wolfram Sang w.sang at pengutronix.de
Thu Sep 15 15:53:20 CEST 2011

> > I think we should use usleep_range for both udelays here? Having a rate
> > of 8000, we'd burn 250us here.
> >
> Yes, I agree that it's a bit long for 8000.
> I tried sleep way but I found the trigger function is called with
> spin_lock held, so it seems we may not be able to sleep here.
> I think the way of dynamically calculate delay suggested by Liam has
> Already minimize the affection, especially for high sample rate, it
> may work more efficiency than sleep (context switch cost).
> Do you think if it's reasonable to accept it?

Yes, it can be fixed when it becomes necessary

Reviewed-by: Wolfram Sang <w.sang at pengutronix.de>

Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20110915/f6022c16/attachment.sig 

More information about the Alsa-devel mailing list