[alsa-devel] [PATCH] snd_hda_intel : add support for built-in audio devices on late 2010 Mac Pro (MacPro 5, 1)

[Paul Menzel]

Dear Rimas,


thank you for your patch.

Am Freitag, den 09.09.2011, 01:31 -0700 schrieb Rimas Avizienis:

> I don't know what the protocol is around here for submitting patches,

I guess patches formatted using `git format-patch -s` are appreciated
for easier application.

Important is the Signed-off-by line which is required [1].

> but I spent the evening hacking the snd_hda_intel ALSA driver
> (specifically alc882_quirks.c) to add support for the built in audio
> devices on the late 2010 Mac Pro (MacPro 5,1) and I figured I should
> get it out into the world before I get lazy.

Good idea.

> Previously, the analog line out and optical digital I/Os worked if you
> specified the model=imac24 parameter when loading the module.
> However, the analog input and front headphone jack didn't.  With this
> patch, all inputs and outputs seem to work properly and I've cleaned
> up the mixer interface (no source selection, no phantom inputs or
> outputs).

Could you attach (I think the size limit of this list is 70 KB) or
upload the output of `alsa-info.sh` [2] without and with your patch
applied.

> Hope someone finds this useful!

I guess a lot of people do.

Please resend as [PATCH v2]. I think the maintainer is on vacation right
now so it might take some days until your patch gets reviewed.


Thanks,

Paul


[1] http://www.mjmwired.net/kernel/Documentation/SubmittingPatches
[2] http://alsa-project.org/main/index.php/Help_To_Debug
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20110909/934977e2/attachment.sig