[alsa-devel] [PATCH] [PATCH]ASoC:blackfin:add ad73311 card driver name

Scott Jiang scott.jiang.linux at gmail.com
Wed Sep 7 07:42:59 CEST 2011


2011/9/6 Mark Brown <broonie at opensource.wolfsonmicro.com>:
> On Tue, Sep 06, 2011 at 03:46:09PM -0400, Scott Jiang wrote:
>> ASoC doesn't copy codec name to card driver now.
>> ALSA lib need this info to find the proper card config.
>> So add card name in snd_soc_card, asoc will copy this name to snd_card.
>
> Your changelog doesn't correspond to your code:
>
>>  static struct snd_soc_card bf5xx_ad73311 = {
>>       .name = "bfin-ad73311",
>> +     .driver_name = "AD73311",
>
>There should already be enough information available to userspace to identify
> that the card is a Blackfin card with ad73311.
>
Yes, card name contains enough info, but alsa lib doesn't use it.
My alsa lib version is 1.0.24. It uses driver name to find card config
not short name nor long name.

> Since the driver_name you're setting only contains the name of the CODEC it looks likely to
> cause more collisions anyway as other systems may use the same CODEC.
>
It is a historical result. all cards config of blackfin in alsa lib
use these names.

one more question, I found nobody changed this in their drivers.
Do their cards config in alsa lib acctually take effect?


More information about the Alsa-devel mailing list