[alsa-devel] [RFC 2/5] compress: add compress parameter definations
pierre-louis.bossart at linux.intel.com
Fri Sep 2 21:54:49 CEST 2011
Thank you Paul for your feedback. We will fix all the typos/formatting
issues. You flagged two important points, see my answers below.
> > +/** struct SndAudioCodecDescriptor - description of codec capabilities
> > + * @maxChannels: maximum number of audio channels
> > + * @minBitsPerSample: Minimum bits per sample of PCM data <FIXME: needed?>
> > + * @maxBitsPerSample: Maximum bits per sample of PCM data <FIXME: needed?>
> More elaborate explanation for the FIXME (in the commit message)?
These fields were defined by OpenMAX AL and make sense for a software
implementation of encoders/decoders. In our case the DSP may be a 24-bit
CPU, or a 32-bit one, or a 16-bit one with double precision. I believe
it's useless to specify the internal PCM format to be used by the DSP,
this should be defined by the firmware implementers.
We decided to leave these fields for now, and see if anyone had a good
reason to keep them. If no one speaks up they will be removed.
> > + * @isFreqRangeContinuous: TRUE if the device supports a continuous range of
> > + * sampling rates between minSampleRate and maxSampleRate;
> > + * otherwise FALSE <FIXME: needed?>
This also comes from OpenMAX AL. I don't know of any hardware
implementation where the audio rate can be specified with an arbitrary
value. Again if we don't see anyone needing this field, it'll be
More information about the Alsa-devel