[alsa-devel] [PATCH 2/2] ASoC: wm8711: Add proper mask for wm8711_set_dai_fmt

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Oct 31 13:37:50 CET 2011

On Fri, Oct 28, 2011 at 11:12:07AM +0800, Axel Lin wrote:
> Add mask for BIT[3:2] (the Input Audio Data Bit Length Select)
> of WM8711_IFACE(07h) register.
> Otherwise, BIT[3:2] will be always set to 0b00 here.

Your changelog here isn't terribly clear and doesn't really correspond
to the change well.  Here you say you're masking something but...

> -	u16 iface = 0;
> +	u16 iface = snd_soc_read(codec, WM8711_IFACE) & 0x000c;

...what you're actually doing is preserving the existing values of some
register bits.  Nevertheless the change looks good so applied.

More information about the Alsa-devel mailing list