[alsa-devel] [patch] [ALSA] hwdep: silence integer overflow warning
dan.carpenter at oracle.com
Fri Oct 28 10:55:20 CEST 2011
On Fri, Oct 28, 2011 at 09:33:11AM +0200, walter harms wrote:
> Am 28.10.2011 08:45, schrieb Dan Carpenter:
> > On Thu, Oct 20, 2011 at 09:39:23AM +0200, walter harms wrote:
> >> I am not sure how SNDRV_MINOR_HWDEPS is used further
> > Either device = SNDRV_MINOR_HWDEPS or device = SNDRV_MINOR_HWDEPS + 1
> > are fine (equivalent) but it's a fair point. Your version is nicer.
> > I'll redo the patch.
> An other question is:
> Should the user be informed that the device is modified ?
> The Problem i see is that a user parameter is silently modified
> and buggy code will come through.
That would be an API change.
This is cut and pasted code, and we've had this exact discussion
before for sound/core/rawmidi.c a year ago. You were involved in
the discussion too. :P
More information about the Alsa-devel