[alsa-devel] [PATCH v7 2/3] ASoC: da7210: Add support for line out and DAC

Ashish Chavan ashish.chavan at kpitcummins.com
Fri Oct 21 13:05:32 CEST 2011


On Fri, 2011-10-21 at 11:24 +0100, Mark Brown wrote:
> On Fri, Oct 21, 2011 at 03:19:15PM +0530, Ashish Chavan wrote:
> > On Fri, 2011-10-21 at 10:00 +0100, Mark Brown wrote:
> 
> > > That'd be fine but there's no DAPM code in the patch, only code to
> > > unconditionally enable on init.
> 
> > Yes, because DAPM part for those IOs is already covered by DAPM patch.
> 
> Ah, you should split that out of the DAPM patch into here - the DAPM bit
> won't work without the enable bits (as I understand it).
> 

Yes, your understanding is correct. Actually I acted bit lazy here by
not splitting, assuming that both patches are going to get merged
shortly. Do you think is it mandatory to do that? Or can I repost the
patch after just resolving merge issue?


Thanks,

-- Ashish (GNU FAN)




More information about the Alsa-devel mailing list