[alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Oct 21 12:23:50 CEST 2011

On Fri, Oct 21, 2011 at 03:17:26PM +0530, Ashish Chavan wrote:
> On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:

> > This explanation would better placed next to the code in the probe -
> > it's that code which looks out of place in a Linux driver.

> Only problem with that is the code to enable individual IOs is not at
> one place and is scattered in the probe(). Should I place all such
> things in a single block in probe() and put the comment above that?

That sounds like a good idea - it's fine to split them up per feature
being enabled but if the big comment is in front of all of them that'd
be really helpful.

More information about the Alsa-devel mailing list