[alsa-devel] [PATCH] ASoC: Suppress early calls to snd_soc_dapm_sync()

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Oct 7 16:33:42 CEST 2011

On Fri, Oct 07, 2011 at 05:18:19PM +0300, Péter Ujfalusi wrote:
> On Friday 07 October 2011 14:34:02 Mark Brown wrote:

> >  	card->instantiated = 1;
> > +	snd_soc_dapm_sync(&card->dapm);

> Without prior snd_soc_dapm_new_widgets() call we just moved the kernel crash
> here.

As I keep saying new_wigets() is orthogonal to the syncing.  They are
two totally separate issues.  There's a good solid reason why I didn't
mention any issues with uninitialized widgets in the changelog which is
that this patch is not intended to help with that in any way, it's
intended to stop us wasting our time (and potentially introducing pops
and clicks from bouncing power) performing needless syncs while starting

The syncs that are being suppressed are totally pointless regardless of
anything else.

More information about the Alsa-devel mailing list