[alsa-devel] [PATCH] ASoC: OMAP machines: Fix kernel crash due to changes in core

[Péter Ujfalusi]

On Friday 07 October 2011 14:46:36 Mark Brown wrote:
> > - From the remaining drivers the soc_dapm_sync need to be removed. If
> > they do funky stuff with their widgets we might need to add
> > snd_soc_dapm_new_widgets() for their init call to be sure they are not
> > crashing.
> 
> new_widgets() is orthogonal to the sync(), there is now a stronger
> requirement for it though.

Yes, new_widgets() is instantiating the new widgets + sync()
IMHO it is going to be rare case when machine drivers would need to do this.

> > I have converted some of the OMAP machine drivers according to point 2
> > after this patch. I only changed those which seamed obvious.
> 
> Yeah, I didn't apply all those patches as they depended on this one.

I'll rewrite the series to skip the sync -> new_widgets() step.

--
Péter