[alsa-devel] [PATCH v2] ASoC: Add support for cs42l73 codec

[Austin, Brian]

>> 
>> +static unsigned int cs42l73_get_xspfs_coeff(u32 rate)
>> +{
>> +     int i;
>> +     for (i = 0; i < ARRAY_SIZE(cs42l73_asrc_rates); i++) {
>> +             if (cs42l73_asrc_rates[i] == rate)
>> +                     return i + 1;
>> +     }
>> +     return 0;               /* 0 = Don't know */
> You could return -EINVAL.
This is a correct value to return, not an error. It just means that it takes longer
to lock the port if we do not know the sample rate

> 
> I don't see implementation of digital_mute function.  Is it going to be added later?
> 
I forgot that.  I can add it before I submit.

Thanks,
Brian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3917 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20111005/9859ff82/attachment-0001.p7s