[alsa-devel] [RFC 05/12] ASoC: twl6040: Simplify custom put_volsw callback

Ujfalusi, Peter peter.ujfalusi at ti.com
Tue Oct 4 18:34:25 CEST 2011

On Tue, Oct 4, 2011 at 6:26 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Oct 04, 2011 at 02:39:42PM +0300, Peter Ujfalusi wrote:
>> Return -EINVAL in the unlikely event, if the function has been called
>> for unhandled control. This way we can remove one check in the code.
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
> I'll apply this but as with the discussion with the Maxim devices the
> other day it'd be better if there were some sort of loud warning if we
> ever hit the error case as it means that the CODEC driver is disagreeing
> with itself.

Agreed, I'll put dev_err for the error cases.


More information about the Alsa-devel mailing list