[alsa-devel] [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Oct 3 19:01:22 CEST 2011

On Mon, Oct 03, 2011 at 12:03:19PM -0400, Paul Gortmaker wrote:
> On 11-10-03 06:30 AM, Mark Brown wrote:

> > That's exactly what I'm running at the minute with no problem...

> Then I'm guessing you don't have the option for it enabled (as

I'm pretty sure I'd have noticed if I wasn't building the driver, my
systems would be a lot less noisy than it currently is.

> Thanks Axel, I'll squish this into the commit that adds module.h
> to all the other sound drivers that have it missing.

Now that we've worked out what it's for I don't see any reason not to
apply Axel's patch right now so I've done that.

It would be useful if you could send your patches for module.h
upstream, there's no reason to avoid sending them now and it'd be useful
to cut down on the noise from small merge issues.

More information about the Alsa-devel mailing list