[alsa-devel] [PATCH] ASoC: Fix setting update bits for WM8741_DACRMSB_ATTENUATION

Axel Lin axel.lin at gmail.com
Mon Oct 3 05:09:01 CEST 2011

After checking the code and datasheet, I think what we want in the second
snd_soc_update_bits call is to update WM8741_DACRMSB_ATTENUATION register

Signed-off-by: Axel Lin <axel.lin at gmail.com>
I don't have this hardware handy, thus I only check the the code and datasheet.
The bug is there since commit 992bee40 "ASoC: Initial WM8741 CODEC driver".
I'd appreciate if someone can test this patch.

 sound/soc/codecs/wm8741.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c
index 78c9e5a..a42b282 100644
--- a/sound/soc/codecs/wm8741.c
+++ b/sound/soc/codecs/wm8741.c
@@ -462,7 +462,7 @@ static int wm8741_probe(struct snd_soc_codec *codec)
 			    WM8741_UPDATELM, WM8741_UPDATELM);
 	snd_soc_update_bits(codec, WM8741_DACRLSB_ATTENUATION,
 			    WM8741_UPDATERL, WM8741_UPDATERL);
-	snd_soc_update_bits(codec, WM8741_DACRLSB_ATTENUATION,
+	snd_soc_update_bits(codec, WM8741_DACRMSB_ATTENUATION,
 			    WM8741_UPDATERM, WM8741_UPDATERM);
 	snd_soc_add_controls(codec, wm8741_snd_controls,

More information about the Alsa-devel mailing list