[alsa-devel] [PATCH 1/3] ASoC: davinci-pcm: latch EDMA errors

[Mark Brown]

On Fri, Sep 30, 2011 at 05:23:01PM -0400, Ben Gardiner wrote:
> The davinci-pcm driver currently ignores all EDMA completion callbacks that
> could be indicating an error.

> Latch any edma error-status callbacks and report them as SNDDRV_PCM_POS_XRUN
> like is done in fsl_dma.c.

Nothing in this patch ever seems to clear the flag which seems rather
extreme.  I'd expect that if you're going to do this then the flag would
be cleared after one error has been reported.

> In testing when an error occured early-on in playback the stream did not halt,
> but several underruns were reported until eventually the stream halted.

> Is there a better way to report HW errors up the stack?

Not really, and it's not clear that it's constructive to try -  if
there's a problem that doesn't otherwise cause a failure then generally
the user will intervene.