[alsa-devel] [PATCH] [ALSA] usb-audio - Support for Roland GAIA SH-01 Synthesizer

John F Leach jfleach at jfleach.com
Sun Nov 27 23:15:30 CET 2011

> Yes, I can fix it by myself.
> But, the patch doesn't pass checkpatch.pl test, so I postpone for
> now.
> John, please fix warnings scripts/checkaptch.pl gives as much as
> possible.  Some warnings can be ignored (e.g. over 80 chars), but
> space issues should be fixed at least.


I replaced the spaces with tabs, I didn't realize I was supposed to run checkpatch.pl before submitting.
How do I fix the ERROR: space prohibited after that '&' (ctx:WxW)?  All of the other table entries look like this.

$ scripts/checkpatch.pl 0001-ALSA-usb-audio-Support-for-Roland-GAIA-SH-01-Synthes.patch
ERROR: space prohibited after that '&' (ctx:WxW)
#28: FILE: sound/usb/quirks-table.h:1638:
+	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {

WARNING: line over 80 characters
#45: FILE: sound/usb/quirks-table.h:1655:
+				.data = & (const struct snd_usb_midi_endpoint_info) {

ERROR: space prohibited after that '&' (ctx:WxW)
#45: FILE: sound/usb/quirks-table.h:1655:
+				.data = & (const struct snd_usb_midi_endpoint_info) {

total: 2 errors, 1 warnings, 37 lines checked

0001-ALSA-usb-audio-Support-for-Roland-GAIA-SH-01-Synthes.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


John F Leach

More information about the Alsa-devel mailing list