[alsa-devel] [PATCH] ASoC: samsung: drop unknown Kconfig symbol
broonie at opensource.wolfsonmicro.com
Thu Nov 24 23:22:12 CET 2011
On Thu, Nov 24, 2011 at 08:59:08PM +0100, Paul Bolle wrote:
> On Thu, 2011-11-24 at 19:19 +0000, Mark Brown wrote:
> > The cost of extra platforms is really
> > very low and people actually send me patches for the OpenMoko devices
> > from time to time (much more frequently than for most other boards) so
> > at least someone cares.
> But - repeating my message - none of those patches made the code in the
> mainline tree buildable.
Which is a problem because... (and note that you mean "selectable in
> I don't have any stake in the GTA01 code. So I don't really mind
> deferring this discussion to (say) the end of the v3.3 merge period.
> But, surely, there must be a point where one can conclude that
> unbuildable code is just that?
No. Removing this code has negative value. There is no meaningful cost
in having it in mainline; your patch has been the biggest piece of work
so far other than updates done by people actively working on the
machine. On the other hand the OpenMoko guys from time to time send
useful patches and report interesting bugs (they sent a patch only last
week in fact) and are definitely a user for the code (which is more than
can be said for most of the legacy boards in mainline).
Please take a step back, think about what value would be brought by
making this change.
More information about the Alsa-devel