[alsa-devel] [PATCH 2/5] ASoC: OMAP4: omap-dmic: Initial support for OMAP DMIC

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Nov 23 16:28:56 CET 2011


On Wed, Nov 23, 2011 at 05:24:41PM +0200, Péter Ujfalusi wrote:
> On Wednesday 23 November 2011 14:30:50 Mark Brown wrote:
> > Meh, I guess.  It's hard to love code-wise.

> So you would prefer me to enable the OMAP DMIC's clocks at pcm_trigger:start 
> time, and disable them on pcm_trigger:stop?

I don't know that that's the best place, but it does feel like we ought
to be able to do better than we are (and obviously if the clocks are
required for writing to the registers that does change things a little).
Perhaps there's not actually anything better given the restrictions,
it's just that like I say it's hard to love the code.


More information about the Alsa-devel mailing list