[alsa-devel] [PATCH] ALSA: ASoC: cs4720: use snd_soc_cache_sync()

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Nov 22 16:35:39 CET 2011


On Tue, Nov 22, 2011 at 04:23:05PM +0100, Daniel Mack wrote:

> The bug is reproducible by setting the output volume to 50% before
> sending the device to suspend. After wakeup, amixer still reports the
> old volume level, but the codec is in fact set to 100%. Changing it to
> 50% doesn't do anything, but to any other level has an effect. This is
> clearly a cache sync bug, but the piece that's missing is the reason why
> my patch does the right thing.

That's very odd, not ringing any bells at all.  It's not like the
existing code is trying to do anything clever with skipping writes, it
just blasts in all the register values and it's affecting two different
registers.

In any case, the patch is moving to factor code out in favour of core
facilities so it's a good idea anyway.


More information about the Alsa-devel mailing list