[alsa-devel] [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET

Lars-Peter Clausen lars at metafoo.de
Tue Nov 22 13:39:04 CET 2011


On 11/22/2011 02:46 AM, Axel Lin wrote:
> According to the datasheet:
> The BIT[5:4] of ADC Control Register 2 is to control the word width.
>         00 = 25 Bits
>         01 = 20 Bits
>         10 = 16 Bits
>         11 = Invalid
> 
> Thus, the AD1836_ADC_WORD_OFFSET should be defined as 4.
> 
> Signed-off-by: Axel Lin <axel.lin at gmail.com>

Acked-by: Lars-Peter Clausen <lars at metafoo.de>

Thanks

> ---
>  sound/soc/codecs/ad1836.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/codecs/ad1836.h b/sound/soc/codecs/ad1836.h
> index 444747f..dd7be0d 100644
> --- a/sound/soc/codecs/ad1836.h
> +++ b/sound/soc/codecs/ad1836.h
> @@ -34,7 +34,7 @@
>  
>  #define AD1836_ADC_CTRL2               13
>  #define AD1836_ADC_WORD_LEN_MASK       0x30
> -#define AD1836_ADC_WORD_OFFSET         5
> +#define AD1836_ADC_WORD_OFFSET         4
>  #define AD1836_ADC_SERFMT_MASK         (7 << 6)
>  #define AD1836_ADC_SERFMT_PCK256       (0x4 << 6)
>  #define AD1836_ADC_SERFMT_PCK128       (0x5 << 6)



More information about the Alsa-devel mailing list