[alsa-devel] [PATCH 2/2] ASoC: sdp4430: Fix Panda support

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Nov 21 15:36:05 CET 2011

On Mon, Nov 21, 2011 at 04:29:54PM +0200, Ujfalusi, Peter wrote:
> On Mon, Nov 21, 2011 at 4:19 PM, Mark Brown

> > Well, that's rather different to what your patch did - I'd expect your
> > patch would also be avoiding setting up all the not connected stuff on
> > Panda.  Perhaps what's needed is platform data (which can have a DT
> > representation when that comes) which represents the differences and can
> > include the name to use?

> Ultimately this is the plan, but for 3.2 it would have been too big of a change.
> I just happen to had the DMIC support done locally first (will send it soon).
> Just reordered the patches, since we feel that 3.2 kernel would
> deserve fix for the
> Panda audio, and obviously the DMIC will go for 3.3.

I'd suggest just jumping straight to platform data now, making it
mandatory and using that to grab the name.  That'll be more ready for
device tree and make life a bit easier for people carrying patches for
further derivatives.  The platform data can then be extended to support
new features and a device tree binding added for it.

Please also fix the word wrapping in whatever mailer you're using.

More information about the Alsa-devel mailing list