[alsa-devel] [PATCH 2/2] ASoC: sdp4430: Fix Panda support

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Nov 21 14:38:36 CET 2011

On Mon, Nov 21, 2011 at 03:14:06PM +0200, Peter Ujfalusi wrote:

> -	if (!machine_is_omap_4430sdp())
> +	if (machine_is_omap_4430sdp())
> +		snd_soc_sdp4430.name = "OMAP4 SDP";
> +	else if (machine_is_omap4_panda())
> +		snd_soc_sdp4430.name = "OMAP4 Panda";
> +	else

I'm not thrilled by this given that I'd imagine this'll end up like
Beagle and have lots of derivatives.  Why not just change the string to
be something generic along the lines of "OMAP4 audio reference design"
rather than the name of a particular board?

More information about the Alsa-devel mailing list