[alsa-devel] [PATCH 2/6] ASoC: alc5632: Fix compile without CONFIG_I2C

[Leon Romanovsky]

On Wed, Nov 16, 2011 at 12:35, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Nov 16, 2011 at 12:06:59PM +0200, Leon Romanovsky wrote:
>
>> +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
>>  static __devinit int alc5632_i2c_probe(struct i2c_client *client,
>>                               const struct i2c_device_id *id)
>>  {
>> @@ -1203,24 +1204,27 @@ static struct i2c_driver alc5632_i2c_driver = {
>>       .remove =  __devexit_p(alc5632_i2c_remove),
>>       .id_table = alc5632_i2c_table,
>>  };
>> +#endif
>
> This is only needed if the driver supports more than one control
> interface.  If it only supports I2C then this should be sorted out at
> Kconfig stage.
It is the same as your WM9081 codec, you have entry in Kconfig and
CONFIG_I2C in the code.

Anyway this codec is not usable without I2C, so we can drop this patch.

>



-- 
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | leon at leon.nu