[alsa-devel] [PATCH] ASoC: alc5632: rename volume/switch contols for master and speaker volumes.
leon at leon.nu
Mon Nov 14 22:50:05 CET 2011
On Mon, Nov 14, 2011 at 23:39, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Sun, Nov 13, 2011 at 09:53:13PM +0200, Leon Romanovsky wrote:
>> - SOC_DOUBLE_TLV("Line Playback Volume",
>> + SOC_DOUBLE_TLV("Speaker Playback Volume",
>> ALC5632_SPK_OUT_VOL, 8, 0, 31, 1, hp_tlv),
> This looks really suspicious, why are we renaming the line output as a
> speaker output? This might be appropriate on your board but if the
> drivers aren't part of the CODEC it might not be appropriate on another
There are two main reasons:
1) We are changing SPK_OUT_VOL which on the schematics marked as a
speaker, and we want to be as close as possible to the datasheet.
2) We are tired to explain to users that the speaker volume controlled
by "Line Playback Volume" in alsamixer.
>> ALC5632_LINE_IN_VOL, 8, 0, 31, 1, vol_tlv),
>> - SOC_DOUBLE_TLV("Stereo DAC Playback Volume",
>> + SOC_DOUBLE_TLV("Master Playback Volume",
>> ALC5632_STEREO_DAC_IN_VOL, 8, 0, 63, 1, vdac_tlv),
>> - SOC_DOUBLE("Stereo DAC Playback Switch",
>> + SOC_DOUBLE("Master Playback Switch",
> This looks fine.
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | leon at leon.nu
More information about the Alsa-devel