[alsa-devel] [PATCH] asoc: tegra: wm8903: Simplify pin disconnect

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Nov 1 19:09:57 CET 2011

On Tue, Nov 01, 2011 at 09:26:11AM -0700, Taylor Hutt wrote:

> (Note that this patch fails the kernel patch checker because
>  the 'M' macro produces an error that it's value should be enclosed
>  in parenthesis; this is not actually possible for this use & expansion.)

So, this whole patch doesn't look like a Linux patch in either the code
itself or the way it's presented.  I remember having similar problems
before with patches you've submitted but this is even further off the
mark than previously.  I did start replying in detail but there's so
many really basic issues from the coding and patch submission style
level up that it was taking too long.

In general whenever you're modifying code (kernel or otherwise) if what
you're doing doesn't visually resemble the rest of the system there's
probably a problem.

More information about the Alsa-devel mailing list