[alsa-devel] [PATCH] ASoC: snd_soc_hw_bulk_write_raw: Use the codec's hw_write callback
broonie at opensource.wolfsonmicro.com
Wed May 11 22:00:45 CEST 2011
On Wed, May 11, 2011 at 12:05:14PM -0700, Lars-Peter Clausen wrote:
> Currently there are two places in the snd_soc_cache code where the function to
> write to the hardware is determined by looking at the control_type.
> One lookup is done when the cache is initialized the other is done in
> snd_soc_hw_bulk_write_raw. This requires, that when the spi or i2c write function
> is changed, that both places are updated.
> To avoid missing one of them use the codec's hw_write callback in
> snd_soc_hw_bulk_write_raw instead of looking at the control_type.
> Also this allows to use other bus types to do raw writes instead of limiting it
> to spi and i2c.
You're missing the bigger picture here where the raw bulk write doesn't
work at all at the minute as it doesn't include the register. Dimitris
said he was going to fix this, I suspect this will collide with that
more important fix.
Please do also bear in mind my previous feedback about fixing the line
lengths and general formatting in your commit logs. It's rather hard to
read the above.
More information about the Alsa-devel