[alsa-devel] [PATCH] ASoC: factor out intel_scu_ipc related read/write

[Lu Guanqun]

On Mon, May 09, 2011 at 11:14:23AM +0800, Koul, Vinod wrote:
> On Sat, 2011-05-07 at 19:18 +0530, Lu, Guanqun wrote:
> > Hi Mark,
> > 
> > How do you think of this approach?
> > 
> > Hi Vinod,
> > 
> > I don't have the mfld hardware, so it's a not tested patch. I want your
> > ack or dis-ack on this. :)
> > 
> > > +	case SND_SOC_INTEL_SCU:
> > > +		if (io_types[i].addr_bits != 16 || io_types[i].data_bits != 8)
> > > +			return -EINVAL;
> > > +
> > > +		codec->hw_read = snd_soc_16_8_intel_scu_read;
> > > +		codec->hw_write = snd_soc_16_8_intel_scu_write;
> > > +		codec->control_data = codec;
> > 
> > Another way to do this to simply override codec->read and codec->write
> > with the intel_scu_read/write stuff.  But then I realize we may later
> > take advantage of soc cache, therefore it's not appropriate to simply
> > override these two operations.
> Let me test it out...
> 
> Meanwhile, i am not sure if this is a good idea.
> We can try enabling cache but will it help? Have you tried that on mrst?

As the first step, we can bypass the soc cache...
I haven't tried it on mrst yet.

> 
> The reason for my paranoia is the SCU API, in past it had issues when we
> do block writes it, something which syncing the cache can cause.
> + Alan for his comments...
> 
> 
> -- 
> ~Vinod
> 

-- 
guanqun