[alsa-devel] [PATCH v2 01/10] ASoC: upd9976: Add Renesas uPD9976 codec driver

[Lu Guanqun]

On Sat, May 07, 2011 at 10:27:35PM +0800, Mark Brown wrote:
> > changing it to `if (upd9976->ira >= 0 && !upd9976->irq_mem) is logically
> > ok, but it introduces more indentation for a large block of code...
> 
> Put it in a function if that's an issue.

OK.

> 
> > > These look like regular routing controls to me...  If they do need to be
> > > set with magic writes they should be platform data but things like
> > > pseudo differential inputs are normally just represented as two single
> > > ended inputs for which userspace just happens to choose a path that
> > > looks differential.
> 
> > The above DMIC output might fit routing control in some way, but I think
> > the MIC2 configuration is hardware specific, this is not related to
> > routing quite much. Let me check whether it's easy to be implemented as
> > a routing control or platform data...
> 
> Really, this is *very* common - a pseudo differential input is just two
> single ended inputs that happen to be used to fake a differential input
> on a given board.  It's likely that a board will use the same setup most
> of the time (though sometimes it does change) but they should still not
> be configuring this with magic register writes in the machine driver.

As this should not be configured in machine driver, I'll make it a
control so that user is about to change it (this should only be set
once, and leave it there untouched).

-- 
guanqun