[alsa-devel] [PATCH 01/19] ASoC: upd9976: Add Renesas uPD9976 codec driver

[Koul, Vinod]

On Wed, 2011-05-04 at 20:35 +0530, Lu, Guanqun wrote:
> On Wed, May 04, 2011 at 10:34:51PM +0800, Mark Brown wrote:
> > On Wed, May 04, 2011 at 09:44:58PM +0800, Lu Guanqun wrote:
> > 
> > Overall this looks very good, a few minor points below.
> > 
> > > +static inline unsigned int upd9976_read(struct snd_soc_codec *codec,
> > > +					unsigned int reg)
> > > +{
> > 
> > I guess these SCU write functions are going to be shared with other
> > CODECs for this CPU - we should probably push this into the soc-cache
> > for them.
> 
> Yes, currently it's the same read/write operation as in sn95031 codec.
I would not do that yet, as I don't see any more codecs using this
interface today or in near future :)


-- 
~Vinod