[alsa-devel] [PATCH 08/19] ASoC: upd9976: add DMIC support

[Lu Guanqun]

On Wed, May 04, 2011 at 11:03:39PM +0800, Dimitris Papastamos wrote:
> On Wed, May 04, 2011 at 09:45:34PM +0800, Lu Guanqun wrote:
> > Signed-off-by: Lu Guanqun <guanqun.lu at intel.com>
>   
> > +	SND_SOC_DAPM_MIXER("PCM2 IN Mix", SND_SOC_NOPM, 0, 0, NULL, 0),
> > +	SND_SOC_DAPM_MIXER("PCM2 IN No Mix", SND_SOC_NOPM, 0, 0, NULL, 0),
> 
> Mixer instead of Mix?
> 
> > +	/* Mux */
> > +	SND_SOC_DAPM_MUX("PCM2 Left", SND_SOC_NOPM, 0, 0,
> > +			 &upd9976_pcm2_left_mux_control),
> > +	SND_SOC_DAPM_MUX("PCM2 Right", SND_SOC_NOPM, 0, 0,
> > +			 &upd9976_pcm2_right_mux_control),
> 
> Append Mux.
> 
> >  	/* PGA */
> >  	SND_SOC_DAPM_PGA("HP Playback Left", UPD9976_DRVPOWERCTRL,
> >  			 2, 0, NULL, 0),
> >  	SND_SOC_DAPM_PGA("HP Playback Right", UPD9976_DRVPOWERCTRL,
> >  			 1, 0, NULL, 0),
> >  
> > +	SND_SOC_DAPM_PGA("AADC Left", SND_SOC_NOPM, 0, 0, NULL, 0),
> > +	SND_SOC_DAPM_PGA("AADC Right", SND_SOC_NOPM, 0, 0, NULL, 0),
> > +
> > +	SND_SOC_DAPM_PGA("DMIC Gain", UPD9976_DMICCTRL1, 7, 0, NULL, 0),
> 
> Append PGA.

Seems I'm not clear on the naming :) Thanks for correction. I'll change
these names.

-- 
guanqun