[alsa-devel] [PATCH 3/3] ASoC: soc-cache: Ignore !codec->writable_register() during syncing

Dimitris Papastamos dp at opensource.wolfsonmicro.com
Mon Mar 28 11:35:01 CEST 2011


On Sat, Mar 26, 2011 at 05:29:41PM +0000, Mark Brown wrote:
> On Thu, Mar 24, 2011 at 01:45:19PM +0000, Dimitris Papastamos wrote:
> > When syncing the cache, if the driver has given us a writable_register()
> > callback, use it to not sync any non-writable registers.
> > 
> > Signed-off-by: Dimitris Papastamos <dp at opensource.wolfsonmicro.com>
> 
> Thinking about this again I'm actually thinking we should really be
> warning if we ever find a need to sync a non-writable register - given
> that we suppress writes of the default value this'd mean that we'd have
> had to have written to the register at some point in the past which
> means that something messed up somewhere.

Yea that makes sense.  I will send in a patch.

Thanks,
Dimitris


More information about the Alsa-devel mailing list