[alsa-devel] [PATCH] TerraTec DMX 6Fire USB: Don't leak firmware when usb6fire_fw_ihex_init() fails.

Jesper Juhl jj at chaosbits.net
Thu Mar 24 21:44:34 CET 2011

We need to release_firmware() what we request_firmware()'ed when 
usb6fire_fw_ihex_init() fails or we'll leak memory.

Signed-off-by: Jesper Juhl <jj at chaosbits.net>
 firmware.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/usb/6fire/firmware.c b/sound/usb/6fire/firmware.c
index 9081a54..2761392 100644
--- a/sound/usb/6fire/firmware.c
+++ b/sound/usb/6fire/firmware.c
@@ -254,6 +254,7 @@ static int usb6fire_fw_ezusb_upload(
 	ret = usb6fire_fw_ihex_init(fw, rec);
 	if (ret < 0) {
+		release_firmware(fw);
 		snd_printk(KERN_ERR PREFIX "error validating ezusb "
 				"firmware %s.\n", fwname);
 		return ret;

Jesper Juhl <jj at chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

More information about the Alsa-devel mailing list