[alsa-devel] [Device-drivers-devel] [PATCH] ASoC: ad74111: new codec driver
broonie at opensource.wolfsonmicro.com
Sat Mar 26 19:09:42 CET 2011
On Sat, Mar 26, 2011 at 01:52:48PM -0400, Mike Frysinger wrote:
> On Sat, Mar 26, 2011 at 08:21, Mark Brown wrote:
> > A few of your patches have this sort of additional change in them.
> > While the cleanup is good it would be better to split it into a separate
> > patch. Seeing the unrelated change slows down review and it'll also
> > create extra merge issues when applying or cherry picking the driver
> > back to older kernels.
> in general i agree, but for moving literally one line i dont generally
> worry about it
It's a one line patch that totally changes the shape of the diff for
that hunk. As I said above this slows down review, it's jarring as one
has to stop and reverse engineer from the change if was intentional and
if it is sensible. It could be some unrelated cleanup, it could be (and
frequently is) context that got included in the diff by mistake.
> > Again, drop the -codec unless this is part of a MFD.
> when i looked at the history of things, it seemed like it's the ASoC
> maintainers sticking "-codec" on stuff. so should i go through
> existing drivers and revert that back ?
Yes, they were included by mistake as a result of automated changes in
the multi-component merges.
More information about the Alsa-devel