[alsa-devel] [PATCH 1/2] ASoC: SSM2602: drop rate and sample bits constraints

Mark Brown broonie at opensource.wolfsonmicro.com
Sat Mar 26 13:44:09 CET 2011

On Sat, Mar 26, 2011 at 03:28:58AM -0400, Mike Frysinger wrote:
> From: Cliff Cai <cliff.cai at analog.com>
> Signed-off-by: Cliff Cai <cliff.cai at analog.com>
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>

I suspect this change is incomplete and should also be setting the
symmetric_rates flag in the driver which does the equivalent thing in
the core as this code is doing.  Looking at the code some symmetry
handling is required as the driver is setting the same registers for
playback and capture rates so simultaneous playback and record with
different rates is not supported?

Converting to symmetric_rates would definitely be a good thing.

More information about the Alsa-devel mailing list