[alsa-devel] [PATCH 2/16] ALSA: VIA HDA: Add support for VT1802

[Takashi Iwai]

At Mon, 21 Mar 2011 15:22:39 +0800,
Lydia Wang wrote:
> 
> -	if (spec->codec_type != VT2002P && spec->codec_type != VT1812)
> +	if (spec->codec_type != VT2002P &&
> +		spec->codec_type != VT1812 &&
> +		spec->codec_type != VT1802)

Better to create a new macro, something like:

   #define VT1812_COMPATIBLE(spec) \
	((spec)->codec_type == VT2002P ||\
	 (spec)->codec_type == VT1812 ||\
	 (spec)->codec_type == VT1802)

instead of open-coding in all places.

> +static struct hda_verb vt1802_volume_init_verbs[] = {
> +	/* Special verbs */
> +	/*{0x1, 0xf93, 0xc3},
> +	{0x1, 0xfa2, 0x70},
> +	{0x1, 0xfe0, 0x04},
> +	{0x1, 0xfe3, 0xfc},
> +	{0x1, 0xff0, 0x39},
> +	{0x1, 0xfa1, 0x58},
> +	{0x1, 0xfd9, 0x0b},
> +	{0x1, 0xfdb, 0x20},
> +	{0x1, 0xfb0, 0x2b},*/

Why are these disabled?  And what do they do?


thanks,

Takashi