[alsa-devel] [PATCH 1/16] ALSA: VIA HDA: Add new power management function

[Takashi Iwai]

At Mon, 21 Mar 2011 15:20:37 +0800,
Lydia Wang wrote:
> 
> +void set_widgets_power_state_vt1716S(struct hda_codec *codec)

Missing static.

> +	/* Mono out */
> +	/* SW4(28h)->MW1(29h)-> PW12 (2ah)*/
> +	present = snd_hda_codec_read(codec, 0x1c, 0,
> +				     AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;

Use snd_hda_jack_detect().

> +	if (present)
> +		mono_out = 0;
> +	else {
> +		present =
> +		snd_hda_codec_read(codec, 0x1d, 0,
> +				   AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;

Ditto.

> +void set_widgets_power_state_vt2002P(struct hda_codec *codec)

Missing static.

> +	/* Class-D */
> +	/* PW0 (24h), MW0(18h/14h), MUX0(34h) */
> +	present =
> +	snd_hda_codec_read(codec, 0x25, 0,
> +			   AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;

Use snd_hda_jack_detect().

> +	/* Mono Out */
> +	present =
> +	snd_hda_codec_read(codec, 0x26, 0,
> +			   AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;

Ditto.

> +void set_widgets_power_state_vt1812(struct hda_codec *codec)

Missing static.

> +	/* Internal Speaker */
> +	/* PW0 (24h), MW0(14h), MUX0(34h) */
> +	present =
> +	snd_hda_codec_read(codec, 0x25, 0,
> +			   AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;

Use snd_hda_jack_detect().

> +	/* Mono Out */
> +	/* PW13 (31h), MW13(1ch), MUX13(3ch), MW14(3eh) */
> +	present =
> +	snd_hda_codec_read(codec, 0x28, 0,
> +			  AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;

Ditto.


thanks,

Takashi