[alsa-devel] [PATCH] ALSA: HDA: Remove over-initialization of mux in ALC269VB

[Takashi Iwai]

At Fri, 11 Mar 2011 09:51:37 +0100,
David Henningsson wrote:
> 
> On 2011-03-10 12:54, Takashi Iwai wrote:
> > At Thu, 10 Mar 2011 08:59:22 +0100,
> > David Henningsson wrote:
> >>
> >> Takashi, would you like to give this one a thought to make sure I
> >> haven't missed any case where this verb is needed. For both models (amic
> >> and dmic), the verb is re-issued, and the autoparser would either add a
> >> mux, or at least set it to a correct start.
> >
> > Could you give some sample alsa-info outputs affected by this bug?
> 
> Hmm, at least I can get you codec proc (attached) and PCI IDs (8086:27d8 
> (rev 02), SSID 1043:8437). Let me know if you need anything else.

Thanks, I'll check it, too.

> > Basically, setting the verbs in that init table should be harmless
> > if the driver overwrites the setting properly in alc269_auto_init()
> > or via amp-cache/verb-cache on resume.
> 
> Ok, although the initialisation verb is still superfluous :-)

Yes, I can apply the patch but we can rip off cc to stable.

> > Does the patch like below fix the issue?
> 
> It does fix the issue when I run it in hda-emu, thanks! I've asked the 
> person with the hardware to test it there as well and I'm awaiting his 
> reply.

Good to hear.  Let me know if it's confirmed to work.


Takashi