[alsa-devel] [PATCH] ASoC: Fix double addition of prefixes due to widget prefixing

Jarkko Nikula jhnikula at gmail.com
Wed Mar 9 12:47:48 CET 2011


On Wed,  9 Mar 2011 11:34:12 +0000
Mark Brown <broonie at opensource.wolfsonmicro.com> wrote:

> We're not only prefixing all controls, we're also prefixing the widget
> names in the runtime data. This causes us to add the prefix twice - once
> when using the widget name to generate the control name and once when
> adding the control.
> 
> Really we shouldn't be prefixing the widget names at all, the matching
> code should be handing this as we always know which DAPM context a
> widget came from and always display the widget name in terms of a DAPM
> context.  However, we're quite close to the merge window and that's
> relatively invasive.
> 
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-dapm.c |   29 ++++++++++++++++++++++++++---
>  1 files changed, 26 insertions(+), 3 deletions(-)
> 
No problem anymore on N900.

Acked-by: Jarkko Nikula <jhnikula at gmail.com>


More information about the Alsa-devel mailing list