[alsa-devel] [PATCH] ASoC: Remove module probe announcements from CODEC drivers
broonie at opensource.wolfsonmicro.com
Tue Mar 1 21:21:54 CET 2011
On Tue, Mar 01, 2011 at 02:17:09PM -0600, Timur Tabi wrote:
> Can I get a justification for this change? On my boards, the CS4270 driver is
> compiled in-kernel, not as a module, and so when the kernel boots, the driver
> announces itself when it's loaded. I like this a lot, which is why I always put
> a pr_info() in the __init function of my modules.
It's rather chatty, especially where one has unused modules compiled
into the kernel, and displayed on the (usually slow serial) console by
default. Having lots of drivers announce themselves in this fashion
gets rather spammy, at the minute only a very small proportion do so.
As a matter of policy Linux drivers generally don't do this.
Printing a message when the driver is actually binding to hardware can
be useful, mainly if it's something like announcing the device revision,
but doing so at module load isn't really conveying anything meaningful.
More information about the Alsa-devel